Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport objc-rtcstats-export.patch #15

Merged
merged 1 commit into from May 26, 2020
Merged

Backport objc-rtcstats-export.patch #15

merged 1 commit into from May 26, 2020

Conversation

dbrgn
Copy link
Contributor

@dbrgn dbrgn commented May 26, 2020

While this patch works on master (and was officially merged in [1]), it
does not apply on M83 since the RTC_OBJC_TYPE macro did not yet exist
back then.

This commit drops the RTC_OBJC_TYPE wrappers and instead just exports
the required symbols.

[1] https://webrtc.googlesource.com/src/+/87a6e5ab4d8f0baf4e2a9b7752b43d825f9c0ce1

While this patch works on master (and was officially merged in [1]), it
does not apply on M83 since the RTC_OBJC_TYPE macro did not yet exist
back then.

This commit drops the RTC_OBJC_TYPE wrappers and instead just exports
the required symbols.

[1] https://webrtc.googlesource.com/src/+/87a6e5ab4d8f0baf4e2a9b7752b43d825f9c0ce1
@dbrgn dbrgn requested a review from lgrahl May 26, 2020 13:57
@dbrgn
Copy link
Contributor Author

dbrgn commented May 26, 2020

(For context, RTC_OBJC_TYPE allows prefixing symbols to avoid symbol collision with other libraries that may be linked into an application together with WebRTC.)

@dbrgn dbrgn merged commit c79c029 into master May 26, 2020
@dbrgn dbrgn deleted the fix-objc-patch branch May 26, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants