-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flash of unstyled content #33
Comments
Thanks, very nice of you to say! It shouldn't do the flash... do you have a sample to reproduce this? |
I seem to have lost the speedy toggle in the refactor. I'll get that back in; it'll speed up rule insertion a lot and should make this less of an issue. Another ugly workaround is to compile with Lemme know if you have a sample though, cheers. |
Yep, I can confirm that when Thanks though, it seems like you know what’s going on 👍 Feel free to close this whenever you’re comfortable. |
The next release will bring back the speedy flag. I'll bring a dev build for npmcdn too. Will close this once that's done. Thanks for the feedback, and do let me know if the issue pops up again. |
do you have any feedback you'd like to share? anything I could make better? what is your usecase? please and thanks :) |
Thanks for asking, I always have opinions 😊 So I really like the approach. I remember when I first heard about this library it was in Twitter code screenshots that had been retweeted a couple of times and I was intrigued, then when I actually wanted to learn more about the library, I couldn't find it 😖, luckily I dug through my Twitter feed and arrived here. Recently I started building a React project with
I haven't been using it for long (about a week now) so I can't comment on any severe architectural limitations, but there are some gotchas I've found. Specificity issues with pseudo-classes is one. So One thing a will note which probably should be warned about is animations. I haven't tested this, but I assume if you want 60fps you shouldn't be updating your I also want to say, bravo on the implementation! It's really pretty neat how the software works. I saw you had a TODO item for static optimizations, it would be sweet to see a Babel transform or something 😊 Now it's your turn, why did you make this framework, what use cases of yours does it solve, what's your vision for its future? |
This is greeeeeat feedback, thank you much!
I recommend you try out the
So I've recently started building my own thing, and wasn't happy with 1-2 things with every library. aphrodite came closest, but the lack of escape hatches/ async behavior made it hard to use. really wanted a library with no compromises, so I went ahead and built it :) That's all really, no crazy grand vision. It's pretty close to "feature complete", I plan on getting some enhancements in and then polishing it as time goes on. Happy to hear ideas :) |
@calebmer @threepointone OMG I wish we were seeing more dialogs like this. You're both awesome ✨ ༼ つ ◕_◕ ༽つ✨✨✨ |
DOWN WITH NAMING EVERYTHING THAT DOESNT DESERVE A NAME!!!!
|
I’ve found that when the React tree is rendered there is a flash of unstyled content with just the React HTML and without the glamor styles. Is there a suggestion on how to fix this?
Great library by the way! I think this approach makes use of the best of all other CSS-in-JS approaches.
The text was updated successfully, but these errors were encountered: