Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not force tracked pose driver #1

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nwessing
Copy link

Pull Request Templates

Switch template by going to preview and clicking the link - note it not work if you've made any changes to the description.

  • default.md - for contributions to stable packages.
  • lightweight.md - for contributions to pre-release/preview packages use the lightweight merge request template. The quality threshold for reviewing is lower - it prioritizes a lean review process.
  • release.md - for release merge requests.

You are currently using: default.md

Note: these links work by overwriting query parameters of the current url. If the current url contains any you may want to amend the url with &template=name.md instead of using the link. See query parameter docs for more information.

Summary

Summary of the purpose of this merge request.

Contributor Tasks

These tasks are for the merge request creator to tick off when creating a merge request.

  • Pair review with a member of the QA team.
  • Add any release testing considerations to the MR for the next release.
  • Check any relevant CHANGELOG files have been updated.
  • Ensure documentation requirements are met e.g., public API is commented.
  • Consider any licensing/other legal implications for this MR e.g. notices required by any new libraries.
  • Add any relevant labels such as breaking to this MR.
  • If this MR closes a Jira issue, make sure the fix version on the JIRA issue is set to the correct one.

Reviewer Tasks

Add any instructions or tasks for the reviewer such as specific test considerations before this can be merged.

Use emojis in review threads to communicate intent and help contributors.

  • Code reviewed.
  • Non-code assets e.g. Unity assets/scenes reviewed.
  • Documentation has been reviewed. Includes checking documentation requirements are met and not missing e.g., public API is commented.
  • Checked and agree with release testing considerations added to MR for the next release.

Closes JIRA Issue

If this MR closes any JIRA issues list them below in the form Closes PROJECT-#

@MattGrayUL
Copy link

MattGrayUL commented Jan 31, 2023

Hi, I saw your quick deletion of making this PR upstream

We have a low priority ticket to make the automatic adding of a Tracked Pose Driver optional (via an inspector bool that is on by default to avoid a breaking change), it'd be great to know your use-case so I can get this bumped up the priority list into a release :)

@nwessing
Copy link
Author

I made an issue on your repository ultraleap#1393

The gist of it is, we use XR Plugin Management but not TrackedPoseDriver. We have our own equivalent of that component so adding the TrackedPoseDriver on top of it was causing some issues.

If you could get a fix into the release that would be great! Always good not to have to keep my fork in sync to get the latest updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants