Removed hardhat-local-networks-config plugin #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After an update in `deepmerge` library, `hardhat-local-networks-config` stopped working and that lead to our system tests to fail with a mysterious `TypeError: config.chains.has is not a function` error. Until the problem is not fixed in `hardhat-local-networks-config`, the plugin is removed. It was here for convenience and all tests are passing without it. See NomicFoundation/hardhat#2630
nkuba
requested changes
May 3, 2022
We had to remove hardhat-local-networks plugin due to a problem with forking mainnet state for tests (see previous commit).
nkuba
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After an update in
deepmergelibrary,hardhat-local-networks-configstopped working and that lead to our system tests failing with a
mysterious
TypeError: config.chains.has is not a functionerror.Until the problem is not fixed in
hardhat-local-networks-config, theplugin is removed. It was here for convenience and all tests are passing
without it.
See NomicFoundation/hardhat#2630
To test this change, try running system tests on
main:Then, try doing the same on this branch.