Skip to content
This repository has been archived by the owner on Dec 10, 2018. It is now read-only.

Upstream compatiable Multiplexing protocol #114

Closed
lxyu opened this issue Mar 26, 2015 · 4 comments
Closed

Upstream compatiable Multiplexing protocol #114

lxyu opened this issue Mar 26, 2015 · 4 comments

Comments

@lxyu
Copy link
Contributor

lxyu commented Mar 26, 2015

Original discussed here at #88

The Apache Thrift implementation is different from the current implementation of thriftpy: https://issues.apache.org/jira/browse/THRIFT-563

@xvblack
Copy link
Contributor

xvblack commented Mar 26, 2015

I created a patch to TMultiplexingProcessor which take in an additional service_name argument and register the processor directly using the given service_name.

To connect to a TMultiplexingProcessor, TMultiplexingProtocol should be used, which takes a underlying protocol and the service_name for the remote service. When writing new message header, it joins the service_name and function name as the new api, which will be decoded by TMultiplexingProcessor. The current separator is ":".

This should be compatible with the https://issues.apache.org/jira/browse/THRIFT-563 solution.

@GuoJing
Copy link

GuoJing commented Mar 27, 2015

yes, I need this, thank you @xvblack

@lxyu
Copy link
Contributor Author

lxyu commented Apr 15, 2015

Solved in #117

@lxyu lxyu closed this as completed Apr 15, 2015
@bufferoverflow
Copy link

and compatible with this: https://issues.apache.org/jira/browse/THRIFT-1914

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants