This repository has been archived by the owner on Dec 10, 2018. It is now read-only.
Multiplex using service_name #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the signature of register_processor to (service_name, processor) and add TMultiplexingProtocol, which use separator (“:”) to join service_name and function as the api Modified test and example
|
flake8 failed ... @xvblack |
|
Rerun travis ci |
|
Ok, my fault, it's ok, sorry. |
|
It's my fault.The second rerun is done after I pushed another two commits. It seems that travis ci sometimes will fail to bind the server. |
|
Awesome! Thank you very much while this will cause some non-backward-compatible changes, I'll do some more tests before the merge. |
Moved service map from class variable to instance variable
|
I fixed a bug in the last version that the processor map are store in class variable rather than instance variable. |
|
I think this is Ok now and could be merged. |
|
Merged in 5d5b052 with some minor changes on the naming, use |
|
v0.3.0 released with this patch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #114
Change the signature of register_processor to (service_name, processor)
and add TMultiplexingProtocol, which use separator (“:”) to join
service_name and function as the api
Modified test and example