gen: Fix bug for typedefed defaults #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a bug where if a field with a default value is a typedef of a
primitive type, the generated code will be equivalent to,
type Timestamp int64
var value *Timestamp = ptr.Int64(42)
This will fail because you cannot assign a `*int64` to a `*Timestamp`.
This commit fixes this issue by generating a `_Timestamp_ptr` function
similar to one generated for other types.
abhinav
commented
Aug 25, 2017
| @@ -18,6 +18,10 @@ struct Event { | |||
| 2: optional Timestamp time // optional typedef | |||
| } | |||
|
|
|||
| struct DefaultPrimitiveTypedef { | |||
| 1: optional State state = "hello" | |||
There was a problem hiding this comment.
This would previously generated code that wouldn't compile
kriskowal
approved these changes
Aug 26, 2017
|
lgtm |
akshayjshah
approved these changes
Aug 26, 2017
abhinav
added a commit
that referenced
this pull request
Aug 28, 2017
The majority use case for accessing values of optional primitives is to
dereference it as-is or use the default/zero value if not.
This modifies code generation to include accessor functions for optional
primitive fields which return non-pointer versions of those fields.
So instead of,
var foo string
if s.Foo != nil {
foo = *s.Foo
}
doSomething(foo)
Users can do,
doSomething(s.GetFoo())
This should also ease migration for users coming from Apache Thrift.
Resolves #295
Depends on #324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a bug where if a field with a default value is a typedef of a
primitive type, the generated code will be equivalent to,
This will fail because you cannot assign a
*int64to a*Timestamp.This commit fixes this issue by generating a
_Timestamp_ptrfunctionsimilar to one generated for other types.