This repository has been archived by the owner on Jun 22, 2021. It is now read-only.
Remove relative path checks in thrift includes #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Does this preclude the possibility of supporting an IDL root path in the future? Have we surveyed the behavior of the Apache Thrift implementations? Do they all resolve paths relative to the file, or the working directory of the generator? |
kriskowal
suggested changes
Oct 4, 2018
thrift.js
Outdated
| var ns = def.namespace && def.namespace.name; | ||
| var filename = path.join(this.dirname, def.id); | ||
|
|
||
| // If include isn't name, get filename sans *.thrift file extension. |
There was a problem hiding this comment.
We should still forbid paths that start with /.
kriskowal
reviewed
Oct 4, 2018
kriskowal
approved these changes
Oct 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rest of the thriftrw language clients have support for just having
include "typedefs.thrift"instead of specifying relative path as ininclude "./typedefs.thrift"