Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow visitor to set his/her name #3

Closed
Tracked by #7
thtauhid opened this issue Sep 24, 2023 · 4 comments · Fixed by #53
Closed
Tracked by #7

Allow visitor to set his/her name #3

thtauhid opened this issue Sep 24, 2023 · 4 comments · Fixed by #53
Assignees
@LinhNguyenLe2109
Labels
good first issue Good for newcomers hacktoberfest Eligible for hacktoberfest

Comments

@thtauhid
Copy link
Owner

thtauhid commented Sep 24, 2023 •
edited

Create a command such that the user is able to set his/her name.
The name should show in place of visitor
@thtauhid thtauhid added the good first issue Good for newcomers label Sep 24, 2023
@thtauhid thtauhid mentioned this issue Sep 24, 2023
Closed
2 tasks
@thtauhid thtauhid added the hacktoberfest Eligible for hacktoberfest label Sep 24, 2023
thtauhid pushed a commit that referenced this issue Oct 1, 2023
@RANJEETJ06
Merge pull request #3 from thtauhid/main
1828961 
Update README.md
@LinhNguyenLe2109
Copy link
Collaborator

Hi, I believe I can handle this issue

This was referenced Oct 1, 2023
Merged
Closed
Paulie-Aditya added a commit to Paulie-Aditya/terminal-portfolio that referenced this issue Oct 2, 2023
@Paulie-Aditya
added code so that it doesn't break after thtauhid#3
ed61337
@thtauhid thtauhid linked a pull request Oct 2, 2023 that will close this issue
added setname functionality #53
Merged
@Paulie-Aditya
Copy link
Contributor

few things to add:
about command should show the name set by the user
the command.toLowerCase should be removed so that people can enter their name in capitals too

@thtauhid
Copy link
Owner Author

thtauhid commented Oct 2, 2023 •
edited

Hi @Paulie-Aditya can you create a new issue mentioning these two?

Join our Discord server to discuss ideas, ask questions, and collaborate with others.

@thtauhid
Copy link
Owner Author

thtauhid commented Oct 2, 2023

Implemented through #53

@thtauhid thtauhid closed this as completed Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LinhNguyenLe2109 LinhNguyenLe2109

Labels
good first issue Good for newcomers hacktoberfest Eligible for hacktoberfest
Projects
Terminal Portfolio
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added setname functionality LinhNguyenLe2109/terminal-portfolio
3 participants
@thtauhid @LinhNguyenLe2109 @Paulie-Aditya