Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch class wrapper missing 'values' method #56

Closed
5 of 8 tasks
duburcqa opened this issue May 28, 2020 · 2 comments
Closed
5 of 8 tasks

Batch class wrapper missing 'values' method #56

duburcqa opened this issue May 28, 2020 · 2 comments
Labels
enhancement Feature that is not a new algorithm or an algorithm enhancement
Projects
Issue/PR Categories

Comments

@duburcqa
Copy link
Collaborator

duburcqa commented May 28, 2020 •
edited

  • I have marked all applicable categories:
    • exception-raising bug
    • RL algorithm bug
    • documentation request (i.e. "X is missing from the documentation.")
    • new feature request
  • I have visited the source website, and in particular read the known issues
  • I have searched through the issue tracker and issue categories for duplicates
  • I have mentioned version numbers, operating system and environment, where applicable:

0.2.2 (master commit de556fd) 1.5.0+cu101 3.6.9 (default, Apr 18 2020, 01:56:04)
[GCC 8.4.0] linux

The Batch class implements keys method but values is missing. It is not a major issue but it would be nice to add it, both for convenience and consistency with the dict API.
@Trinkle23897
Copy link
Collaborator

Trinkle23897 commented May 28, 2020 •
edited

Thanks! I'll add it in the next commit.

@duburcqa
Copy link
Collaborator Author

Nice ! Thank you 👍

@Trinkle23897 Trinkle23897 added the enhancement Feature that is not a new algorithm or an algorithm enhancement label May 29, 2020
@Trinkle23897 Trinkle23897 added this to TODO in Issue/PR Categories via automation May 29, 2020
@Trinkle23897 Trinkle23897 moved this from TODO to Other feature requests in Issue/PR Categories May 29, 2020
BFAnas pushed a commit to BFAnas/tianshou that referenced this issue May 5, 2024
@Trinkle23897
fix thu-ml#56
59d19d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature that is not a new algorithm or an algorithm enhancement
Projects
No open projects
Issue/PR Categories
Other feature requests
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Trinkle23897 @duburcqa