Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/fix trainer fct notebooks #1009

Merged

Conversation

carlocagnetta
Copy link
Contributor

@carlocagnetta carlocagnetta commented Dec 13, 2023

  • I have added the correct label(s) to this Pull Request or linked the relevant issue(s)
  • I have provided a description of the changes in this Pull Request
  • I have added documentation for my changes
  • If applicable, I have added tests to cover my changes.
  • I have reformatted the code using poe format
  • I have checked style and types with poe lint and poe type-check
  • (Optional) I ran tests locally with poe test
    (or a subset of them with poe test-reduced) ,and they pass
  • (Optional) I have tested that documentation builds correctly with poe doc-build

This PR resolves #1008

@carlocagnetta
Copy link
Contributor Author

@opcode81 This is the PR for the issue we discussed today
@MischaPanch Could you please review it?
I also changed a minor thing in the .rst files of the docu to upgrade to CarPole-v1

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea48cc2) 88.06% compared to head (0fc4e9d) 88.06%.

❗ Current head 0fc4e9d differs from pull request most recent head a96b13c. Consider uploading reports for the commit a96b13c to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1009   +/-   ##
=======================================
  Coverage   88.06%   88.06%           
=======================================
  Files          96       96           
  Lines        7531     7531           
=======================================
  Hits         6632     6632           
  Misses        899      899           
Flag Coverage Δ
unittests 88.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MischaPanch
Copy link
Collaborator

The build fails because you committed a different python version to the notebook metadata. Could you undo this pls?

@MischaPanch MischaPanch self-requested a review December 13, 2023 22:43
@MischaPanch
Copy link
Collaborator

The build on windows fails, but it has nothing to do with the changes here. Seems some caching problem in CI. If it appears on master, I'm gonna solve it in a separate PR. Merging this, thanks for the docs fixes!

@MischaPanch MischaPanch merged commit b7df31f into thu-ml:master Dec 14, 2023
2 of 5 checks passed
@carlocagnetta carlocagnetta deleted the docs/fix_trainer_fct_notebooks branch February 8, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docu fix: result = trainer.run()
3 participants