Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publish workflow, first preparation for next release #1067

Merged
merged 8 commits into from
Mar 4, 2024

Conversation

MischaPanch
Copy link
Collaborator

@MischaPanch MischaPanch commented Mar 2, 2024

@Trinkle23897 This PR requires your attention!

I think time has come to make the next release. Since there are rather massive changes/extensions, I believe we should make a bump in the major version, i.e., go to 1.0.0

It doesn't mean everything is stable, of course, but we can go to 2.0.0 with more stable low-level interfaces later.

I have added a publish workflow which should be triggered by a github release. We can discuss the release notes together, if you want. For it to work, you'll need to set the PYPI_TOKEN var in the repositories secrets.

I also made adjustments in the readme and in the docs about contributors, pls have a look whether you agree (especially with the latter).

In the next week we'll add more docs, more adjustments in the readme, and shift around some tutorials to make everything more cohesive for the next release.

You mentioned that you had some action-based release mechanism in mind already. I don't mind replacing the current publishing workflow with something else, if you prefer

@opcode81 @maxhuettenrauch @carlocagnetta @bordeauxred FYI

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.17%. Comparing base (1aee41f) to head (eb99da3).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1067   +/-   ##
=======================================
  Coverage   88.17%   88.17%           
=======================================
  Files         100      100           
  Lines        8172     8172           
=======================================
  Hits         7206     7206           
  Misses        966      966           
Flag Coverage Δ
unittests 88.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Trinkle23897
Copy link
Collaborator

Trinkle23897 commented Mar 3, 2024

Could you provide your PYPI account, so that I can add you to maintainer?

Added:
Screenshot 2024-03-03 at 9 01 56 AM

Trinkle23897
Trinkle23897 previously approved these changes Mar 3, 2024
@MischaPanch MischaPanch merged commit 6746a80 into master Mar 4, 2024
6 of 10 checks passed
@MischaPanch MischaPanch deleted the CI/add-publish-workflow branch March 4, 2024 11:21
ZhengLi1314 pushed a commit to ZhengLi1314/tianshou_0.5.1 that referenced this pull request Apr 15, 2024
ZhengLi1314 pushed a commit to ZhengLi1314/tianshou_0.5.1 that referenced this pull request Apr 15, 2024
ZhengLi1314 pushed a commit to ZhengLi1314/tianshou_0.5.1 that referenced this pull request Apr 15, 2024
ZhengLi1314 pushed a commit to ZhengLi1314/tianshou_0.5.1 that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants