-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add publish workflow, first preparation for next release #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1067 +/- ##
=======================================
Coverage 88.17% 88.17%
=======================================
Files 100 100
Lines 8172 8172
=======================================
Hits 7206 7206
Misses 966 966
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Trinkle23897
previously approved these changes
Mar 3, 2024
ZhengLi1314
pushed a commit
to ZhengLi1314/tianshou_0.5.1
that referenced
this pull request
Apr 15, 2024
ZhengLi1314
pushed a commit
to ZhengLi1314/tianshou_0.5.1
that referenced
this pull request
Apr 15, 2024
ZhengLi1314
pushed a commit
to ZhengLi1314/tianshou_0.5.1
that referenced
this pull request
Apr 15, 2024
ZhengLi1314
pushed a commit
to ZhengLi1314/tianshou_0.5.1
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Trinkle23897 This PR requires your attention!
I think time has come to make the next release. Since there are rather massive changes/extensions, I believe we should make a bump in the major version, i.e., go to 1.0.0
It doesn't mean everything is stable, of course, but we can go to 2.0.0 with more stable low-level interfaces later.
I have added a publish workflow which should be triggered by a github release. We can discuss the release notes together, if you want. For it to work, you'll need to set the PYPI_TOKEN var in the repositories secrets.
I also made adjustments in the readme and in the docs about contributors, pls have a look whether you agree (especially with the latter).
In the next week we'll add more docs, more adjustments in the readme, and shift around some tutorials to make everything more cohesive for the next release.
You mentioned that you had some action-based release mechanism in mind already. I don't mind replacing the current publishing workflow with something else, if you prefer
@opcode81 @maxhuettenrauch @carlocagnetta @bordeauxred FYI