Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README, minor changes in procedural example #1068

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

opcode81
Copy link
Collaborator

@opcode81 opcode81 commented Mar 2, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.16%. Comparing base (7c970df) to head (b484b77).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1068   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files         100      100           
  Lines        8176     8176           
=======================================
  Hits         7208     7208           
  Misses        968      968           
Flag Coverage Δ
unittests 88.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@MischaPanch MischaPanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge, unless you want to continue working on this PR

@opcode81 opcode81 enabled auto-merge (squash) March 3, 2024 14:02
@opcode81
Copy link
Collaborator Author

opcode81 commented Mar 3, 2024

LGTM, feel free to merge, unless you want to continue working on this PR

I don't have the rights to do that.

@MischaPanch
Copy link
Collaborator

That's weird, you have maintainer rights, which includes push. I guess it's due to the PR rules, which require the forever failing GPU test to pass - maybe maintainers are not allowed to bypass them. I'm going to remove the GPU workflow in the next PR

@MischaPanch MischaPanch merged commit fdb69f1 into thu-ml:master Mar 3, 2024
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants