Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements pertaining to the handling of multi-experiment creation #1131

Merged
merged 6 commits into from
May 5, 2024

Conversation

opcode81
Copy link
Collaborator

@opcode81 opcode81 commented Apr 30, 2024

  • I have added the correct label(s) to this Pull Request or linked the relevant issue(s)
  • I have provided a description of the changes in this Pull Request
  • I have added documentation for my changes and have listed relevant changes in CHANGELOG.md
  • If applicable, I have added tests to cover my changes.
  • I have reformatted the code using poe format
  • I have checked style and types with poe lint and poe type-check
  • (Optional) I ran tests locally with poe test
    (or a subset of them with poe test-reduced) ,and they pass
  • (Optional) I have tested that documentation builds correctly with poe doc-build

Description of changes: see individual commits; should be merged without squashing.

Co-authored by: @maxhuettenrauch

Partly addressed #1129

  * Add class ExperimentCollection to improve usability
  * Remove parameters from ExperimentBuilder.build
  * Renamed ExperimentBuilder.build_default_seeded_experiments to build_seeded_collection,
    changing the return type to ExperimentCollection
  * Replace temp_config_mutation (which was not appropriate for the public API) with
    method copy (which performs a safe deep copy)
@opcode81 opcode81 added high-level-api Mainly affects tianshou.highlevel experiment-eval Issues about evaluation: plots, stats, multiprocessing etc. labels Apr 30, 2024
@MischaPanch MischaPanch marked this pull request as ready for review April 30, 2024 20:52
@MischaPanch MischaPanch enabled auto-merge May 5, 2024 14:24
@MischaPanch MischaPanch disabled auto-merge May 5, 2024 19:41
@MischaPanch MischaPanch merged commit 9fbf28e into thu-ml:master May 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experiment-eval Issues about evaluation: plots, stats, multiprocessing etc. high-level-api Mainly affects tianshou.highlevel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants