DQN Atari examples #187
Merged
DQN Atari examples #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trinkle23897
changed the title
8 tasks
Trinkle23897
changed the title
8 tasks
youkaichao
reviewed
Aug 28, 2020
youkaichao
reviewed
Aug 28, 2020
youkaichao
reviewed
Aug 28, 2020
|
It is amazing these small wrappers are essential for DQN to play atari. Evils are in the details :( |
youkaichao
reviewed
Aug 28, 2020
youkaichao
reviewed
Aug 28, 2020
youkaichao
previously approved these changes
Aug 28, 2020
|
@duburcqa It's ready now and please have a look when you are free. |
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
==========================================
- Coverage 95.75% 95.26% -0.49%
==========================================
Files 39 39
Lines 2425 2430 +5
==========================================
- Hits 2322 2315 -7
- Misses 103 115 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Trinkle23897
previously approved these changes
Aug 29, 2020
youkaichao
approved these changes
Aug 29, 2020
Trinkle23897
approved these changes
Aug 29, 2020
|
Sorry, too many notifications, I missed the request for review :/ |
|
You can still add the comment and the change will appear in my next pr :) |
BFAnas
pushed a commit
to BFAnas/tianshou
that referenced
this pull request
May 5, 2024
This PR aims to provide the script of Atari DQN setting: - A speedrun of PongNoFrameskip-v4 (finished, about half an hour in i7-8750 + GTX1060 with 1M environment steps) - A general script for all atari game Since we use multiple env for simulation, the result is slightly different from the original paper, but consider to be acceptable. It also adds another parameter save_only_last_obs for replay buffer in order to save the memory. Co-authored-by: Trinkle23897 <463003665@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to provide the script of Atari DQN setting:
Since we use multiple env for simulation, the result is slightly different from the original paper, but consider to be acceptable.