Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add C51 algorithm #266
Add C51 algorithm #266
Changes from 10 commits
66c1f95
64f42ce
8e90593
da9e369
8e82d7a
3abf810
631c461
2b43654
b0e7317
3d96e3b
6688aef
a4e8750
e02dbc3
489ecaa
0505b16
ca13004
3c6c4a7
6116eb5
c06fba1
92b2d4c
44cf066
3695f12
22fa78a
3efac01
d315052
dbbfb7d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why
hasattr(obs, "obs")
could be false ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These three are the same as existing DQNPolicy. I guess we can make a separate PR to enhance these things :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I noticed that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like much this approach, but right now I have no idea about to avoid it. Maybe adding
masked_array
method toBatch
class to offer something similar to numpy's masked arrays. Internally it would use the same mechanism, but it would be hidden inBatch
, which is way better in by opinion.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend explicit variable names
_cnt