Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing casts to int by to_torch_as(...) calls in policies when using discrete actions #521

Merged
merged 4 commits into from
Feb 6, 2022
Merged

Fixing casts to int by to_torch_as(...) calls in policies when using discrete actions #521

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0ac0a94
fixing cast to int of returns in PGPolicy
Kenneth-Schroeder Feb 4, 2022
41ee416
change parameter order in to_torch call
Kenneth-Schroeder Feb 4, 2022
dc45d4d
add to_torch import
Kenneth-Schroeder Feb 4, 2022
5ff3145
fix import ordering, ran all contributing make commands
Kenneth-Schroeder Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tianshou/policy/modelfree/pg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import numpy as np
import torch

from tianshou.data import Batch, ReplayBuffer, to_torch_as
from tianshou.data import Batch, ReplayBuffer, to_torch, to_torch_as
from tianshou.policy import BasePolicy
from tianshou.utils import RunningMeanStd

Expand Down Expand Up @@ -131,7 +131,7 @@ def learn( # type: ignore
result = self(minibatch)
dist = result.dist
act = to_torch_as(minibatch.act, result.act)
ret = to_torch_as(minibatch.returns, result.act)
ret = to_torch(minibatch.returns, torch.float, result.act.device)
log_prob = dist.log_prob(act).reshape(len(ret), -1).transpose(0, 1)
loss = -(log_prob * ret).mean()
loss.backward()
Expand Down