Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Trainers as generators #559

Merged
merged 46 commits into from
Mar 17, 2022
Merged

Add Trainers as generators #559

merged 46 commits into from
Mar 17, 2022

Commits on Mar 5, 2022

  1. add docstring :param buffer to offline_trainer in offline.py

    @jamartinh
    jamartinh committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    8bad065 View commit details
    Browse the repository at this point in the history

  2. Add param yield_epoch to trainers. if True, converts the function int… 

    …o a generator that yields a 3-tuple (epoch, stats, info) of train results on every epoch.
    @jamartinh
    jamartinh committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    ff9c0c9 View commit details
    Browse the repository at this point in the history

  3. Add trainer geneators for offline.py, offpolicy.py and onpolicy.py . 

    Add tests for trainer generators.
    @jamartinh
    jamartinh committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    2b72992 View commit details
    Browse the repository at this point in the history

  4. fix PEP8 

    fix offline.py
    @jamartinh
    jamartinh committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    9a6a72b View commit details
    Browse the repository at this point in the history

  5. fix PEP8 

    fix onpolicy.py
    @jamartinh
    jamartinh committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    d05f0e0 View commit details
    Browse the repository at this point in the history

  6. fix PEP8

    @jamartinh
    jamartinh committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    5566be0 View commit details
    Browse the repository at this point in the history

  7. fix yapf

    @jamartinh
    jamartinh committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    185c006 View commit details
    Browse the repository at this point in the history

  8. removed comments in format section of Makefile. It produces errors on… 

    … windows make.
    @jamartinh
    jamartinh committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    79f050a View commit details
    Browse the repository at this point in the history

  9. fix isort

    @jamartinh
    jamartinh committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    4cbc7c8 View commit details
    Browse the repository at this point in the history

  10. fix rare error with dict with mypy

    @jamartinh
    jamartinh committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    ffbe30a View commit details
    Browse the repository at this point in the history

  11. fix rare error with dict with mypy

    @jamartinh
    jamartinh committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    23f00d2 View commit details
    Browse the repository at this point in the history

  12. fix docstrings

    @jamartinh
    jamartinh committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    f64eb2d View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2022

  1. refactored offline.py to one iterator class

    @jamartinh
    jamartinh committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    b6b0ed7 View commit details
    Browse the repository at this point in the history

  2. drop test_sac_with_il_trainer_generator.py

    @jamartinh
    jamartinh committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    0f39eac View commit details
    Browse the repository at this point in the history

  3. improve offline.py with best practices on exhausting iterator and cle… 

    …aner less code keeping the same functionality
    @jamartinh
    jamartinh committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    21cdbe6 View commit details
    Browse the repository at this point in the history

  4. Create an Iterator class instead of a generator function, following t… 

    …he sketch in offline.py
    @jamartinh
    jamartinh committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    2483dea View commit details
    Browse the repository at this point in the history

  5. Expose new _iter versions and Iterator Classes

    @jamartinh
    jamartinh committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    88cb63c View commit details
    Browse the repository at this point in the history

  6. Add OffPolicyTrainer as Iterator adn add testing in test_td3.py

    @jamartinh
    jamartinh committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    34feb5b View commit details
    Browse the repository at this point in the history

  7. fix doc format

    @jamartinh
    jamartinh committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    1c7eaef View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. Merge branch 'master' into trainers_as_generators

    @Trinkle23897
    Trinkle23897 committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    4067428 View commit details
    Browse the repository at this point in the history

  2. * Refactored trainers into One BaseTrainer class. 

    * All the procedures are so equal that separating them will make to much unnecessary duplicated complex code

* Included tests in test_ppo.py, test_cql.py and test_rd3.py

* It can be simplified even more, but would break backward Api compatibility
    @jamartinh
    jamartinh committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    5ca6fb8 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'jamh/trainers_as_generators' into train… 

    …ers_as_generators
    @jamartinh
    jamartinh committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    d705744 View commit details
    Browse the repository at this point in the history

  4. fix formatting

    @jamartinh
    jamartinh committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    b4fa395 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/master' into trainers_as_generators

    @Trinkle23897
    Trinkle23897 committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    91c787c View commit details
    Browse the repository at this point in the history

  6. docs

    @Trinkle23897
    Trinkle23897 committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    c1f5f25 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. fix missing import

    @Trinkle23897
    Trinkle23897 committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    b12beb1 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2022

  1. * fix formatting 

    * fix docs
* fix drop "test_c"
    @jamartinh
    jamartinh committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    a4ae2e3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'thu-ml:master' into trainers_as_generators

    @jamartinh
    jamartinh committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    0690d12 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into trainers_as_generators

    @Trinkle23897
    Trinkle23897 committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    e2756f0 View commit details
    Browse the repository at this point in the history

  4. update docs

    @Trinkle23897
    Trinkle23897 committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    c902d61 View commit details
    Browse the repository at this point in the history

  5. update rst

    @Trinkle23897
    Trinkle23897 committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    a3e7e2c View commit details
    Browse the repository at this point in the history

  6. fix early stopping during train [train_step]

    @jamartinh
    jamartinh committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    651726f View commit details
    Browse the repository at this point in the history

  7. * fix early stopping during train train_step 

    * Simplify return logic
    @jamartinh
    jamartinh committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    e6b00e2 View commit details
    Browse the repository at this point in the history

  8. * fix early stopping during train train_step 

    * Simplify return logic
    @jamartinh
    jamartinh committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    4d76843 View commit details
    Browse the repository at this point in the history

  9. * fix early stopping during train train_step 

    * Simplify return logic
    @jamartinh
    jamartinh committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    23ce483 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2022

  1. * fix early stopping during train train_step 

    * Simplify return logic
    @jamartinh
    jamartinh committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    1d707f8 View commit details
    Browse the repository at this point in the history

  2. * fix early stopping during train train_step 

    * Simplify return logic
    @jamartinh
    jamartinh committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    479b794 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2022

  1. Merge branch 'master' into trainers_as_generators

    @Trinkle23897
    Trinkle23897 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    3adf0e1 View commit details
    Browse the repository at this point in the history

  2. fix a bug in BaseTrainer.run return value missing

    @Trinkle23897
    Trinkle23897 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    08f65a6 View commit details
    Browse the repository at this point in the history

  3. change seed to pass ci

    @Trinkle23897
    Trinkle23897 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    5ec4eb3 View commit details
    Browse the repository at this point in the history

  4. learning_type: str

    @Trinkle23897
    Trinkle23897 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    89ce44f View commit details
    Browse the repository at this point in the history

  5. fix ci

    @Trinkle23897
    Trinkle23897 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    a320e68 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. reorg some code

    @Trinkle23897
    Trinkle23897 committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    6df9365 View commit details
    Browse the repository at this point in the history

  2. revert

    @Trinkle23897
    Trinkle23897 committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    7a00daf View commit details
    Browse the repository at this point in the history

  3. missing docs for on-policy trainer

    @Trinkle23897
    Trinkle23897 committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    3ce4f6d View commit details
    Browse the repository at this point in the history

  4. missing docs

    @Trinkle23897
    Trinkle23897 committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    a62cf84 View commit details
    Browse the repository at this point in the history