Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer the right dtype for replay buffers. #64

Merged
merged 1 commit into from
May 29, 2020

Conversation

duburcqa
Copy link
Collaborator

@duburcqa duburcqa commented May 29, 2020

Fix #65

@duburcqa duburcqa mentioned this pull request May 29, 2020
8 tasks
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2020

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   85.25%   85.25%           
=======================================
  Files          29       29           
  Lines        1634     1634           
=======================================
  Hits         1393     1393           
  Misses        241      241           
Flag Coverage Δ
#unittests 85.25% <100.00%> (ø)
Impacted Files Coverage Δ
tianshou/data/buffer.py 97.40% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8af7196...c07f753. Read the comment docs.

@Trinkle23897 Trinkle23897 merged commit dd3e213 into thu-ml:master May 29, 2020
@duburcqa duburcqa deleted the buffer_infer_dtype branch May 29, 2020 14:56
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong dtype for replay buffers
3 participants