Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code error? #7

Closed
xiaolingzang opened this issue Jul 2, 2019 · 2 comments
Closed

code error? #7

xiaolingzang opened this issue Jul 2, 2019 · 2 comments

Comments

@xiaolingzang
Copy link

when you do knowledge encoding, the code use tgt_vocab for knowledge and change
src_vocab_size , but after that the code change back config.src_vocab_size = config.src_vocab_size,there may be a error

@qibinc
Copy link
Collaborator

qibinc commented Jul 2, 2019

Hi @xiaolingzang ,

Thanks for your interest in this work!

You're right! This line should be config.src_vocab_size = src_vocab_size to set it back. Luckily, this doesn't affect anything.. The argument config.src_vocab_size is used in the encoder for x, which is defined before these lines. But still, I'm really grateful that you point this out. I'll fix this in the next update.

Much thanks!

Best
Qibin Chen

@qibinc
Copy link
Collaborator

qibinc commented Jul 3, 2019

Fixed

@qibinc qibinc closed this as completed Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants