Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace antlr3 maven plugin with antlr-runtime #565

Merged
merged 4 commits into from Jan 9, 2019
Merged

Conversation

MyXOF
Copy link
Collaborator

@MyXOF MyXOF commented Jan 8, 2019

You have a dependency on the antlr3 maven plugin. Instead you should depend on the antlr-runtime artifact that matches your antlr3 version.
By Chris

solve #500
checklist 12

@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

Merging #565 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #565      +/-   ##
==========================================
- Coverage   37.96%   37.94%   -0.03%     
==========================================
  Files         551      551              
  Lines       39398    39482      +84     
  Branches     7842     7883      +41     
==========================================
+ Hits        14958    14980      +22     
- Misses      22940    22993      +53     
- Partials     1500     1509       +9
Impacted Files Coverage Δ
.../java/cn/edu/tsinghua/iotdb/sql/parse/ASTNode.java 24.66% <ø> (-0.34%) ⬇️
...ava/cn/edu/tsinghua/iotdb/conf/TsfileDBConfig.java 79.55% <0%> (-1.81%) ⬇️
...u/tsinghua/iotdb/qp/strategy/LogicalGenerator.java 58.82% <0%> (+0.19%) ⬆️
...nghua/iotdb/qp/logical/crud/BasicOperatorType.java 62.5% <0%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c0a2bb...7708e3b. Read the comment docs.

@MyXOF MyXOF merged commit 219effb into master Jan 9, 2019
@MyXOF MyXOF deleted the fix_issue_500 branch January 9, 2019 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants