-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes extensible metrics in remotecv #63
Conversation
Pull Request Test Coverage Report for Build 3704449885
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good stuff, apart from how to measure time. Let's create a function in an utils.py
file that returns current time for measurements (using time.perf_counter_ns). Then we can use it everywhere, instead of duplicating the code. If we decide to change it in the future it's easy. Also add a function to get the difference in seconds (get_interval_seconds(perf_counter_ns_start, perf_counter_ns_end)
). This way if we want to change the function that returns the timings in the future, we can also change this one and the whole codebase just works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by mistake. See comments in approval.
8a9779d
to
b537d1e
Compare
836c525
to
e42d938
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! TYVM!
Will leave merge to after @guilhermef review :) |
fa80b62
to
7703b07
Compare
It doesn't have to be done in this one, but I suggest a more modern approach like Prometheus metrics and taking advantage of the HTTP server we have running on the worker. |
87387ef
to
abc4ade
Compare
Code Climate has analyzed commit 704a2e4 and detected 0 issues on this pull request. View more on Code Climate. |
Awesome work @devppjr |
Great job @devppjr 🚀 |
This PR aims to create metrics for remotecv and make it extensive for defining upstream metrics. So was added the metrics bellow:
For each detector:
For original image, such as Thumbor does:
For each task (image to detect):
closes #60