Prune dead members on startup #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devppjr
requested review from
guilhermef,
marcelometal,
scorphus,
RaphaelVRossi and
maiagripp
Pull Request Test Coverage Report for Build 5616199244
馃挍 - Coveralls |
devppjr
force-pushed
the
prune-dead-members-on-startup
branch
from
a6b0177
to
0b07e46
Compare
scorphus
requested changes
Jul 20, 2023
tests/test_unique_queue.py
Outdated
Comment on lines
129
to
141
| def test_should_prune_dead_members_on_startup(self): | ||
| config.prune_dead_members = True | ||
| worker = UniqueWorker(server=self.redis, queues=["Detect"]) | ||
|
|
||
| self.redis.sadd("resque:workers", "teste1") | ||
| members = self.redis.smembers("resque:workers") | ||
| expect(len(members)).to_equal(2) | ||
|
|
||
| worker.startup() | ||
|
|
||
| members = self.redis.smembers("resque:workers") | ||
| expect(len(members)).to_equal(1) | ||
| expect(str(worker).encode() in members).to_be_true() |
There was a problem hiding this comment.
Aren't we missing a test_should_not_prune_dead_members_on_startup? I think it's important to check both conditions.
There was a problem hiding this comment.
@scorphus Makes sense, what do you think of the test?
devppjr
force-pushed
the
prune-dead-members-on-startup
branch
from
0b07e46
to
673d4bd
Compare
|
Code Climate has analyzed commit 673d4bd and detected 0 issues on this pull request. View more on Code Climate. |
RaphaelVRossi
approved these changes
Jul 20, 2023
scorphus
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When remotecv is killed in kubernetes/docker the environment stay with dead members instances. So this PR aims to add a prune dead members configuration to avoid this problem.
continuation of #78 馃槵