Add rubocop

.github/workflows/main.yml

@@ -37,3 +37,16 @@ jobs:
         with:
           github-token: ${{ secrets.github_token }}
           parallel-finished: true
+  rubocop:
+    name: runner / rubocop
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.1
+      - name: rubocop
+        uses: reviewdog/action-rubocop@v2
+        with:
+          rubocop_version: gemfile
+          reporter: github-pr-check

.rubocop.yml

@@ -4,6 +4,9 @@ Naming/FileName:
 Style/Documentation:
   Enabled: false
 
+Gemspec/RequiredRubyVersion:
+  Enabled: false
+
 Metrics/ClassLength:
   Max: 130
 
@@ -12,3 +15,15 @@ Layout/LineLength:
 
 Metrics/BlockLength:
   Max: 255
+
+Metrics/AbcSize:
+  Max: 74
+
+Metrics/CyclomaticComplexity:
+  Max: 26
+
+Metrics/MethodLength:
+  Max: 44
+
+Metrics/PerceivedComplexity:
+  Max: 26

Gemfile

@@ -3,6 +3,3 @@
 source 'https://rubygems.org'
 
 gemspec
-
-gem 'simplecov',      require: false
-gem 'simplecov-lcov', require: false

lib/thumbor/crypto_url.rb

@@ -7,16 +7,10 @@
 
 module Thumbor
   class CryptoURL
-    attr_writer :computed_key
-
     def initialize(key = nil)
       @key = key
     end
 
-    def computed_key
-      (@key * 16)[0..15]
-    end
-
     def calculate_width_and_height(url_parts, options)
       width = options[:width]
       height = options[:height]

ruby-thumbor.gemspec

@@ -36,4 +36,7 @@ Gem::Specification.new do |s|
 
   s.add_development_dependency 'rake', '~> 13.0'
   s.add_development_dependency 'rspec', '~> 3.10'
+  s.add_development_dependency 'rubocop-rspec', '~> 2.8.0'
+  s.add_development_dependency 'simplecov', '~> 0.21.2'
+  s.add_development_dependency 'simplecov-lcov', '~> 0.8.0'
 end

spec/thumbor/cascade_spec.rb

@@ -10,12 +10,6 @@
 
   subject { Thumbor::Cascade.new key, image_url }
 
-  describe '#new' do
-    it 'should create a new instance passing key and keep it' do
-      expect(subject.computed_key).to eq 'my-security-keym'
-    end
-  end
-
   it 'should raise an error' do
     expect { subject.god_of_war_crop }.to raise_error(NoMethodError)
   end

tasks/rspec.rake

@@ -1,7 +1,4 @@
 # frozen_string_literal: true
 
-begin
-  require 'rspec/core/rake_task'
-  RSpec::Core::RakeTask.new(:spec)
-rescue LoadError
-end
+require 'rspec/core/rake_task'
+RSpec::Core::RakeTask.new(:spec)