Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove warnings #18

Merged
merged 1 commit into from
Jan 12, 2016
Merged

Remove warnings #18

merged 1 commit into from
Jan 12, 2016

Conversation

dx7
Copy link
Contributor

@dx7 dx7 commented Jan 12, 2016

A simple change to avoid boring warnings:

Running tests with RUBYOPT=-w before the changes:

Ruby Warnings found:
   1 lib/thumbor/crypto_url.rb:14: warning: method redefined; discarding old computed_key

@dx7
Copy link
Contributor Author

dx7 commented Jan 12, 2016

Update: I will fix specs in another PR.

guilhermef added a commit that referenced this pull request Jan 12, 2016
@guilhermef
Merge pull request #18 from dx7/remove-warnings
80590a5 
Remove warnings
@guilhermef guilhermef merged commit 80590a5 into thumbor:master Jan 12, 2016
@dx7
Copy link
Contributor Author

dx7 commented Jan 12, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dx7 @guilhermef