Adds the debug option to thumbor urls #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That failure https://travis-ci.org/thumbor/ruby-thumbor/builds/121544114 is only in the Ruby head build, related to installing ffi. So that has nothing to do with this PR. |
|
@okor, now it's passing, but you have to create a test for the debug url |
| @@ -132,6 +132,10 @@ def url_for(options, include_hash = true) | |||
|
|
|||
| url_parts = Array.new | |||
|
|
|||
| if options[:debug] | |||
| url_parts.push('debug') | |||
There was a problem hiding this comment.
This can be written as:
url_parts.push('debug') if options[:debug]
|
@guilhermef my bad 😊 will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's sometimes super helpful to have the debug option, when developing application level cropping logic. So I suggest adding it here.