Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix webp prefix #200

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Fix webp prefix #200

merged 2 commits into from
Mar 14, 2024

Conversation

guilhermef
Copy link
Member

@guilhermef guilhermef commented Jan 31, 2024 •
edited
Loading

The auto_webp part was mistakenly prepended to the root path, instead of being added after it.

Fixes #171

@guilhermef guilhermef requested a review from a team as a code owner January 31, 2024 00:26
@guilhermef guilhermef changed the title Fix webp prefix, fixes #171 Fix webp prefix Jan 31, 2024
@coveralls
Copy link

coveralls commented Jan 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8287216760

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.545%
Totals Coverage Status
Change from base Build 8287187150: 0.0%
Covered Lines: 314
Relevant Lines: 343
💛 - Coveralls

@guilhermef guilhermef mentioned this pull request Jan 31, 2024
Closed
@guilhermef guilhermef merged commit cb9c92c into main Mar 14, 2024
15 checks passed
@guilhermef guilhermef deleted the fix-result-storage-webp-prefix branch March 14, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelometal marcelometal Awaiting requested review from marcelometal marcelometal is a code owner automatically assigned from thumbor/thumbor-main-reviewers

@heynemann heynemann Awaiting requested review from heynemann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking change in result storage v0.6.0
2 participants
@guilhermef @coveralls