Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually give focal point in percentage values #1664

Open
mpdude opened this issue Apr 19, 2024 · 4 comments
Open

Manually give focal point in percentage values #1664

mpdude opened this issue Apr 19, 2024 · 4 comments

Comments

@mpdude
Copy link
Contributor

mpdude commented Apr 19, 2024

I’d like to pass manually selected focal points to Thumbor so that images can be cropped around those. My guess is I should use something like the focal filter, which would effect the crop operation afterwards.

The crop filter requires absolute (pixel) values, I only have percentages.

Could someone give me starting pointers how the necessary conversions could be make in the filter? Can it access the original image size?

Would you accept a PR for such an extension?

Copy link

This issue is stale because it has been open 30 days with no activity. Remove the stale label or add a comment, or this issue will be closed in 15 days. You can always re-open if you still feel this is still an issue. Tag @heynemann for more information.

@github-actions github-actions bot added the Stale label May 20, 2024
@mpdude
Copy link
Contributor Author

mpdude commented May 20, 2024

„This is a comment“

@github-actions github-actions bot removed the Stale label May 20, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove the stale label or add a comment, or this issue will be closed in 15 days. You can always re-open if you still feel this is still an issue. Tag @heynemann for more information.

@github-actions github-actions bot added the Stale label Jun 19, 2024
@mpdude
Copy link
Contributor Author

mpdude commented Jun 19, 2024

„This is a comment“

@github-actions github-actions bot removed the Stale label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant