Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid SOS parameters for sequential JPEG #117

Closed
KevinErath opened this issue Jul 22, 2018 · 4 comments
Closed

Invalid SOS parameters for sequential JPEG #117

KevinErath opened this issue Jul 22, 2018 · 4 comments

Comments

@KevinErath
Copy link

Bug report

Thumbsup image tag: thumbsupgallery/thumbsup
Docker version: 18.03.1-ce
Operating system: Ubuntu 18.04 LTS

All photos made with an Galaxy S8 Phone raise following error. Pictures from other phones like an IPhone doesn't raise the issue:

Unexpected error Error: Error: Error: Command failed: gm identify: Invalid SOS parameters for sequential JPEG (/pictures/test.jpg).
gm identify: Request did not return an image.

    at job.task.then.catch.err (/thumbsup/node_modules/listr-work-queue/lib/index.js:50:14)
    at <anonymous>

I can fix the pictures with running exiftool. For example
exiftool -artist=me test.jpg

It would be cool if the error could be handled, or at least those defect pictures would be skipped, so processing can continue. You can find some work arounds when googling about the issue. Unfortunately those solutions seems to be php-related.

@rprieto
Copy link
Member

rprieto commented Jul 22, 2018

Thanks for reporting the issue! Could you share an example of one of these files?

The latest version actually skips problematic files and prints a summary at the end. The Docker image is lagging behind, but with #114 it should soon be up to date again. Keep an eye out for thumbsupgallery/thumbsup:2.4.1 in the next few days.

@KevinErath
Copy link
Author

KevinErath commented Jul 23, 2018

Thanks for the hint. I just build my own docker image via your dockerfile.
It skips the errornuous files now.

This thread contains an image which should show the error (didn't test it though).
https://stackoverflow.com/questions/48653584/cannot-load-jpeg-with-java-created-by-samsung-phone

It also contains a solution (convert). This solves the issue.

@rprieto
Copy link
Member

rprieto commented Jul 24, 2018

Thanks,

To sum up for anyone with the same issue, this seems to be a bug in Samsung's handling of panorama images. The generated JPEG images have invalid metadata markers, which also trips up other programs such as Adobe Lightroom (see forum) or the JavaFX library.

This Python should fix the affected photos: https://gist.github.com/bcyrill/e59fda6c7ffe23c7c4b08a990804b269. I think this is out of scope of thumbsup, so I'll close the issue if you're OK with it.

@rprieto rprieto closed this as completed Jul 25, 2018
@rprieto
Copy link
Member

rprieto commented Jul 25, 2018

If you want to switch back to the canonical image, version 2.4.1 is now available on DockerHub: thumbsupgallery/thumbsup:2.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants