Box shadow atomic class fix for IE 11 to Edge 18 #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomgenoni
changed the title
danoc
reviewed
Jan 8, 2020
danoc
reviewed
Jan 8, 2020
Co-Authored-By: Daniel O’Connor <doconnor@thumbtack.com>
danoc
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds CSS targeted only at IE 11 through Edge 18 browsers with different, darker
box-shadowvalues so they render closer to what modern browsers use. In the original ticket the fix was to use anoutlinebut visually it's too far off.The top row is how it renders in Chrome/Safari/Firefox. The bottom row is how it looks in IE/Edge with fix applied.
This was tested in all Chrome/Safari/Firefox, iOS Safari, Android Galaxy S9, Windows Phone, IE 11 and all Edge versions including Chromium 79 beta.
Fixes #476