Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark as read not persistent #1443

Open
gtrcoi opened this issue Jun 12, 2024 · 1 comment
Open

Mark as read not persistent #1443

gtrcoi opened this issue Jun 12, 2024 · 1 comment
Assignees
Labels
bug Something isn't working fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Milestone

Comments

@gtrcoi
Copy link

gtrcoi commented Jun 12, 2024

Bug Description

Mark as read post swipe gesture and settings > general > "Mark Read After Viewing Media" does not mark post as read persistantly.

These actions mark posts as read for a moment (1 secondish) before reverting to unread status.

Clicking on post to view post and comments does mark as read as expected.

Video of bug: https://github.com/thunder-app/thunder/assets/24573615/56204a76-85ea-46d2-9e53-126a944e2a60

Expected Behaviour

Viewing media or using assigned gesture action to mark post as read should mark post as read.

Steps to Reproduce

Set gesture action in settings > gestures > Post Swipe Actions to mark as read. Use gesture action.

Enable settings > general > "Mark Read After Viewing Media", then view media (without opening post to view comments)

Additional Context

Started happening after a recent update to the app, iirc a week or so ago.

App Version

0.4.0

Device

Pixel3

OS

Android 12

@gtrcoi gtrcoi added the bug Something isn't working label Jun 12, 2024
@gtrcoi gtrcoi changed the title Mark as read not persistent/working Mark as read not persistent Jun 12, 2024
@hjiangsu hjiangsu self-assigned this Jun 12, 2024
@hjiangsu hjiangsu added the in-progress Indicates that an issue is currently being worked on label Jun 12, 2024
@hjiangsu hjiangsu added this to the 0.5.0 milestone Jun 12, 2024
@hjiangsu
Copy link
Member

Thanks for submitting the issue. I found the cause and have a PR with the fix. This should land in the next nightly build!

@hjiangsu hjiangsu added fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version and removed in-progress Indicates that an issue is currently being worked on labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Projects
None yet
Development

No branches or pull requests

2 participants