Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mark post as read when previewing media on 0.19.4 #1444

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR fixes an issue where instances on v0.19.4 cannot mark a post as read when tapping on the media thumbnail. This is because 0.19.4 removed postId from the MarkPostAsRead endpoint.

Issue Being Fixed

Issue Number: #1443

Screenshots / Recordings

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-06-12.at.15.09.17.1.mp4

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I wonder if it would hurt to pass both postId and postIds for every call to support both versions without an if statement? Not a big deal either way.

@hjiangsu
Copy link
Member Author

I wonder if it would hurt to pass both postId and postIds for every call to support both versions without an if statement? Not a big deal either way.

That was something I thought of as well, but I'm not entirely sure of how the backend processes requests (whether it rejects them or ignores them) so I just played it safe. I am thinking of maybe dropping support for 0.18.x in the near future (maybe in v0.6.0, but nothing set in stone) so it might not be a big issue regardless!

@hjiangsu hjiangsu merged commit c40f69d into develop Jun 13, 2024
1 check passed
@hjiangsu hjiangsu deleted the fix/mark-post-as-read branch June 13, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants