Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed updates for Accent Color settings #457

Closed
machinaeZER0 opened this issue Jul 24, 2023 · 3 comments
Closed

Proposed updates for Accent Color settings #457

machinaeZER0 opened this issue Jul 24, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Milestone

Comments

@machinaeZER0
Copy link
Collaborator

With Accent Color as it's currently implemented, it's not possible to see how the color will look without exiting the Theming page. I have some thoughts on how this could be updated:

  • right now accent color is selected from a list of swatches, and picking a swatch immediately closes the picker. I suggest changing it from a tap-to-change list to a list with radial buttons and a Save button at the bottom. With this change you would be able to "window shop" colors as much as you'd like, with the radial buttons (and Save button) updating in real time to give you a sense of what the color will look like elsewhere in the app. Backing out of this menu would discard your changes, and hitting Save would (nach) save your selected color
  • additional thought: instead of showing your selected color in the Theming page by its name (Red, Blue, etc), I think it would be great to instead show your selected swatch in this space. Again, since currently nothing on this particular page is themed, this gives people another indicator of what their chosen accent color actually looks like
@machinaeZER0 machinaeZER0 added the enhancement New feature or request label Jul 24, 2023
@machinaeZER0
Copy link
Collaborator Author

Adding some mockups as to what I was envisioning!

accent color thunder

accent color 2 thunder

accent color 3 thunder

@CTalvio
Copy link
Collaborator

CTalvio commented Jul 26, 2023

image

How about using the same style of swatches, as the "material you" selection screen? It displays the primary, secondary and tertiary colors as icons for you to quickly see the colors that come with each option.

@machinaeZER0
Copy link
Collaborator Author

That would be really cool!

@micahmo micahmo self-assigned this Sep 5, 2023
@micahmo micahmo added the fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version label Sep 7, 2023
@micahmo micahmo added this to the v0.2.4 milestone Sep 7, 2023
@micahmo micahmo closed this as completed Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Projects
None yet
Development

No branches or pull requests

3 participants