Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accent color picking #708

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Sep 5, 2023

Pull Request Description

This PR adds a couple improvements to theme picking.

  1. Show three-color swatch in settings page and picker.
    • Note: For the secondary color I actually show primaryContainer and for the tertiary color I show secondaryContainer to reflect what the user is most likely to encounter in the app. See the demo.
  2. Keep picker open while selecting accents to show a live preview. Add button to close.

Note that the jagged edges look much better on a physical device.

Issue Being Fixed

Issue Number: #457

Screenshots / Recordings

qemu-system-x86_64_0CSMSr7PBV.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 0f84e3e into thunder-app:develop Sep 7, 2023
1 check passed
@micahmo micahmo deleted the feature/color-picker-improvements branch September 7, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants