Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option/toggle to automatically open links in Reader View #760

Closed
throwawaytime opened this issue Sep 22, 2023 · 4 comments
Closed
Assignees
Labels
enhancement New feature or request fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Milestone

Comments

@throwawaytime
Copy link

throwawaytime commented Sep 22, 2023

This would be helpful as dark mode easily gets destroyed by links to bright white backgrounded pages; reader view addresses that. As a bonus it also eliminates ads and can circumvent paywalls.

@throwawaytime throwawaytime added the enhancement New feature or request label Sep 22, 2023
@throwawaytime throwawaytime changed the title Add an option/toggle to automatically open links in ReaderView Add an option/toggle to automatically open links in Reader View Sep 22, 2023
@hjiangsu
Copy link
Member

Hey @throwawaytime, thanks for the suggestion! After briefly looking at this, it seems like we may be able to get reader view on iOS devices. I'm not sure if Android has a similar implementation of this.

If you know of anything with regards to the Android side, that would be helpful! I'm not seeing this option with the package we use to handle custom tabs. Maybe @micahmo can chime in on this and see if theres a viable solution for Android

References:

  • Safari allows for reader view via enterReaderIfAvailable: API reference

@micahmo
Copy link
Member

micahmo commented Sep 23, 2023

I'm not familiar with this as a standard Android feature. Some browsers and apps have a reader view feature, but I don't think it's something we could easily invoke. That said, I'm fine with this being an iOS-only feature until/unless we have a solution for Android.

@throwawaytime
Copy link
Author

Hey @throwawaytime, thanks for the suggestion! After briefly looking at this, it seems like we may be able to get reader view on iOS devices. I'm not sure if Android has a similar implementation of this.

If you know of anything with regards to the Android side, that would be helpful! I'm not seeing this option with the package we use to handle custom tabs. Maybe @micahmo can chime in on this and see if theres a viable solution for Android

References:

  • Safari allows for reader view via enterReaderIfAvailable: API reference

I am only familiar with it on iOS. This would be a great enhancement even if it has to be iOS-only.

@throwawaytime
Copy link
Author

I'm not familiar with this as a standard Android feature. Some browsers and apps have a reader view feature, but I don't think it's something we could easily invoke. That said, I'm fine with this being an iOS-only feature until/unless we have a solution for Android.

I am only familiar with it on iOS. This would be a great enhancement even if it has to be iOS-only.

@hjiangsu hjiangsu self-assigned this Oct 19, 2023
@hjiangsu hjiangsu added the in-progress Indicates that an issue is currently being worked on label Oct 19, 2023
@hjiangsu hjiangsu added this to the v0.2.5 milestone Oct 19, 2023
@hjiangsu hjiangsu added fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version and removed in-progress Indicates that an issue is currently being worked on labels Oct 19, 2023
@micahmo micahmo mentioned this issue Jan 12, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Projects
None yet
Development

No branches or pull requests

3 participants