Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to toggle reader mode for links on iOS #840

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Oct 19, 2023

Pull Request Description

This PR adds a way to toggle reader mode on iOS when tapping on an external link. This only works when openInExternalBrowser is false as it relies on flutter_custom_tabs parameter.

Issue Being Fixed

Issue Number: #760

Screenshots / Recordings

10de1507-1c78-461c-974b-033af7f3f3f5.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

BTW, I had an idea to bring back the in-app browser you developed with three options (in-app browser, custom tabs, external browser). I thought some people might like the more app-native experience better, and it might allow us to integrate some third-party reader mode on Android (if such a thing exists).

lib/settings/pages/general_settings_page.dart Show resolved Hide resolved
@hjiangsu
Copy link
Member Author

BTW, I had an idea to bring back the in-app browser you developed with three options (in-app browser, custom tabs, external browser)

Hmm, I wonder if there are any users who prefer the in-app browser more than the custom tabs. I haven't heard anything myself but if this is the case, then we can definitely do this!

@hjiangsu hjiangsu merged commit 712c3ae into develop Oct 19, 2023
1 check passed
@hjiangsu hjiangsu deleted the feature/link-reader-mode branch October 19, 2023 16:18
@micahmo
Copy link
Member

micahmo commented Oct 19, 2023

I wonder if there are any users who prefer the in-app browser more than the custom tabs.

Not that they prefer it, per se, but that they want features which would required it. One example would be #729. We can't handle swipe gestures on the custom tabs, but we probably could in app. Another would be, for example, a comment button that jumps straight from a web page to the post comments (like Relay has).

@hjiangsu
Copy link
Member Author

Ahh I see, that makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants