Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User and community avatar support in chips #1318

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

iparks99
Copy link
Contributor

Pull Request Description

Added toggle options to:

  • Settings -> Appearance -> Comments -> Show User Avatar
  • Settings -> Appearance -> Posts -> Post Body Settings -> Show Community Avatar

Wherever there is a User/Community Chip widget, the User/Community's avatar will be displayed if the appropriate toggle option is set to true.

Issue Being Fixed

Enhancement to display user and community avatars in post view.

Issue Number: #600, #1221

Screenshots / Recordings

image
image
image

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM! Nice work, as always!

I only have one question.

  • Settings -> Appearance -> Comments -> Show User Avatar
  • Settings -> Appearance -> Posts -> Post Body Settings -> Show Community Avatar

Since the avatars may appear in other areas than these specifically (e.g., right now, the user avatar will appear in the post body, and in the future they may appear in the feed too), should these settings go under Appearance > Theming > Names?

(This is just an idea and I'd wait to hear @hjiangsu chime in first!)

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu
Copy link
Member

Since the avatars may appear in other areas than these specifically (e.g., right now, the user avatar will appear in the post body, and in the future they may appear in the feed too), should these settings go under Appearance > Theming > Names?

Hmm, I think for now, we can leave them in their respective places. If the amount of settings become large enough, I was thinking of creating a new page to customize user/community avatars and chips under Appearance > User & Community Chips (maybe with a better name 😅). Thoughts @micahmo?

@micahmo
Copy link
Member

micahmo commented Apr 24, 2024

I was thinking of creating a new page to customize user/community avatars and chips under Appearance > User & Community Chips (maybe with a better name 😅).

That makes sense to me! We could also put "Use Display Names" for both users and communities there!

@hjiangsu
Copy link
Member

hjiangsu commented Apr 24, 2024

Yup, we don't have to do that in this PR though - it can be done separately! I'll go ahead and merge this one in. Thanks @iparks99 for the contribution again!

@hjiangsu hjiangsu merged commit 436b12f into thunder-app:develop Apr 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants