Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve markdown appearance #1328

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Improve markdown appearance #1328

merged 2 commits into from
Apr 29, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Apr 25, 2024

Pull Request Description

This PR updates a bit of our markdown styling (in a similar vein as the spoiler changes in #1286) with the following changes.

  • Added some rounding and color to quotes.
  • Added some coloring to code blocks and ensured that inline blocks are colored even in light mode.
  • Added some rounded corners to tables.
  • Removed markdown formatting from text previews.

Screenshots / Recordings

Quotes

Before After
image image

Code / Tables

Before After
image image

@micahmo
Copy link
Member Author

micahmo commented Apr 25, 2024

I pushed another small change to improve the horizontal rule appearance with color and rounded corners.

Before After
image image

hjiangsu
hjiangsu approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very nice QoL improvements 😀

@hjiangsu hjiangsu merged commit 107bca3 into thunder-app:develop Apr 29, 2024
1 check passed
@micahmo micahmo deleted the feature/markdown-improvements branch April 29, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@micahmo @hjiangsu