Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View notifications as correct user #1339

Merged
merged 2 commits into from
May 6, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented May 1, 2024

Pull Request Description

This PR adds support for switching to the context of a different account when tapping on a notification to an account that is not the currently selected one. This uses a technique similar to the "post as other user" feature, where the account is switched without reloading certain parts of the app, and when navigating back, the account is reset, so that whatever you were looking at previously is left untouched. This also works if you were previously browsing anonymously.

I also fixed a small issue related to startup where we would skip the notification check if we weren't started by a notification.

Hide whitespace.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_Fo1yqdttq4.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 5cd3b66 into thunder-app:develop May 6, 2024
1 check passed
@micahmo micahmo deleted the feature/notification-user branch May 6, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants