Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UnifiedPush notifications #1364

Merged
merged 6 commits into from
May 16, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented May 13, 2024

Pull Request Description

This PR fixes the notification server endpoint path and also adds support for a new test endpoint.

qemu-system-x86_64_xKHVGvHVM5.mp4

@micahmo
Copy link
Member Author

micahmo commented May 14, 2024

I pushed another commit which fixes an issue where we'd be missing the ID of the message from notifications generated by UnifiedPush.

@micahmo
Copy link
Member Author

micahmo commented May 15, 2024

I pushed another commit which uses the slimmer payload object for reply notifications.

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit c3d5dc1 into thunder-app:develop May 16, 2024
1 check passed
@micahmo micahmo deleted the feature/notifications-stuff branch May 16, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants