Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more notifications debugging #1397

Merged
merged 3 commits into from
Jun 8, 2024
Merged

Add more notifications debugging #1397

merged 3 commits into from
Jun 8, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented May 29, 2024

Pull Request Description

This PR includes a few changes to improve the notification debugging experience.

  • Display the current UnifiedPush server (by saving and parsing endpoing)
  • Display the current Thunder notification server and availability (using ping)
image

hjiangsu
hjiangsu approved these changes Jun 8, 2024
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 92526c7 into thunder-app:develop Jun 8, 2024
1 check passed
@micahmo micahmo deleted the feature/notification-debugging branch June 9, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@micahmo @hjiangsu