Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially fix for markdown toolbar not showing above system keyboard #1524

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR attempts to fix an issue where the markdown toolbar does not show up above the system keyboard. I believe the issue may be coming from KeyboardDismissOnTap from flutter_keyboard_visibility, but am not entirely certain as I cannot reproduce it on my end.

However, looking at the implementation for KeyboardDismissOnTap, there is some logic that checks whether or not to ignore taps which could be stopping Flutter from being informed when the keyboard is opened? This is a shot in the dark unfortunately.

image

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth a try!

@hjiangsu
Copy link
Member Author

I'll merge this in and create another nightly build to see if this fix fixes the original issue!

@hjiangsu hjiangsu merged commit 01febb4 into develop Aug 12, 2024
1 check passed
@hjiangsu hjiangsu deleted the fix/keyboard-markdown-toolbar branch August 12, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants