Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text preview improvements #631

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Aug 14, 2023

Pull Request Description

This PR improves the compact text post indicators.

  • Add padding and center
  • Make text size a function of the post length
  • Display placeholder icon when body is empty

A possible future enhancement:

  • Use markdown viewer

Review with whitespace off

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

qemu-system-x86_64_p7SSWoidMn.mp4

After

qemu-system-x86_64_g8jwxmsa2M.mp4

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 9a3bb45 into thunder-app:develop Aug 15, 2023
1 check passed
@micahmo micahmo deleted the feature/text-preview-improvements branch August 15, 2023 03:04
@machinaeZER0
Copy link
Collaborator

This is cool, I like the implementation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants