Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign Create Comment Screen #643

Merged
merged 14 commits into from
Aug 19, 2023
Merged

Redesign Create Comment Screen #643

merged 14 commits into from
Aug 19, 2023

Conversation

coslu
Copy link
Contributor

@coslu coslu commented Aug 15, 2023

Pull Request Description

This PR redesigns the UI of the create comment screen and adds some additional improvements to the create post screen.

  • The create comment screen is no longer displayed as a bottom modal sheet. It is now a page that matches the design of the create post page.
  • Allows to upload images in comments. All image buttons in the create post- and comment pages turn into a CircularProgressIndicator while an image is being uploaded.
  • When replying directly to a post, the contents of the post are shown in the 'replying to' area.
  • When the create comment page is opened, the text field has focus and the keyboard opens automatically.
  • When switching back from preview, the previous cursor location is maintained and the text field gains focus. In create post page, body text field gains focus.
  • Create post- and comment pages show an indicator for the currently active account with avatar, display name, user name and instance.
  • Prevents opening the create post- and comment pages when not logged in (was possible through FAB).

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Screenshot_20230815_184921

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

coslu added 12 commits August 9, 2023 14:27
@coslu
Redesign UI of create comment page
f32ddad
@coslu
Add image uploading to comments and localization
8c3d6b9
@coslu
Refactor create_comment_page
30bff18
@coslu
Show contents of the post that is replied to
a458d1b
@coslu
Remember cursor location and show progress indicator when uploading i…
727ffd5 
…mage
@coslu
Add active account indicator to comment page
78b611a
@coslu
Merge remote-tracking branch 'upstream/develop' into create_comment
205fded 
# Conflicts:
#	lib/community/pages/create_post_page.dart
#	lib/l10n/app_en.arb
#	lib/l10n/app_es.arb
#	lib/l10n/app_fi.arb
#	lib/l10n/app_sv.arb
#	lib/shared/media_view.dart
@coslu
Add active account indicator to create post page
63ff08a
@coslu
Prevent opening create post page when not logged in
716f8fe
@coslu
Fixes and small changes
e38d4dd
@coslu
Merge remote-tracking branch 'upstream/develop' into create_comment
18ae21a 
# Conflicts:
#	lib/l10n/app_en.arb
#	lib/l10n/app_es.arb
#	lib/l10n/app_fi.arb
#	lib/l10n/app_sv.arb
@coslu
Update changelog
9f4135f
micahmo
micahmo reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks lovely!

lib/community/pages/create_post_page.dart Show resolved Hide resolved
lib/post/pages/create_comment_page.dart Outdated Show resolved Hide resolved
lib/post/pages/post_page.dart Outdated Show resolved Hide resolved
lib/utils/image.dart Outdated Show resolved Hide resolved
@coslu
Merge remote-tracking branch 'upstream/develop' into create_comment
d3fba61 
# Conflicts:
#	CHANGELOG.md
#	lib/community/pages/create_post_page.dart
#	lib/community/widgets/community_sidebar.dart
#	lib/l10n/app_en.arb
#	lib/l10n/app_es.arb
#	lib/l10n/app_fi.arb
#	lib/l10n/app_sv.arb
hjiangsu
hjiangsu reviewed Aug 18, 2023
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, great job on this @coslu! This is a pretty big change so thanks for taking it on 🗡️

I just added some comments to some of the existing comments to provide my thoughts. Overall, I think this is pretty good, and should be good to go once the comments are addressed/conflicts are fixed!

lib/community/pages/create_post_page.dart Show resolved Hide resolved
lib/post/pages/create_comment_page.dart Outdated Show resolved Hide resolved
@coslu coslu requested a review from hjiangsu August 18, 2023 18:12
micahmo
micahmo approved these changes Aug 19, 2023
View reviewed changes
Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you addressed the comments and fixed the merge conflicts, I'm going to go ahead and merge this so people can start using it. Thanks again!

@micahmo micahmo merged commit 0ab909d into thunder-app:develop Aug 19, 2023
1 check passed
@ajsosa ajsosa mentioned this pull request Aug 25, 2023
Closed
@micahmo micahmo mentioned this pull request Aug 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahmo micahmo micahmo approved these changes

@hjiangsu hjiangsu Awaiting requested review from hjiangsu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coslu @micahmo @hjiangsu