Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing and Exporting Settings to JSON #644

Merged
merged 7 commits into from
Sep 5, 2023

Conversation

hjiangsu
Copy link
Member

Pull Request Description

Initial implementation for handling exporting and importing app settings to device. This saves a JSON file containing the user preferences.

This has been tested a bit on iOS, would need to check functionality on Android devices

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu
Copy link
Member Author

@micahmo feel free to test this out on Android to make sure all the permissions are enabled for storage!

@micahmo
Copy link
Member

micahmo commented Aug 18, 2023

Will do! If it works on Android, are you ready to merge?

@hjiangsu
Copy link
Member Author

Yeah, I think this can be merged in if its all good - I just have the settings placed in the general settings, but we can move that around after if needed!

@hjiangsu hjiangsu marked this pull request as ready for review August 18, 2023 16:27
@micahmo
Copy link
Member

micahmo commented Aug 18, 2023

Just a quick update on this. Unfortunately it's crashing on Android for me with this error.

android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.CREATE_DOCUMENT cat=[android.intent.category.OPENABLE] typ=json (has extras) }

Need more time to investigate!

@micahmo
Copy link
Member

micahmo commented Aug 19, 2023

Alright, I tracked this one down! Apparently the issue was related to the MIME type, and just json isn't "valid", it wanted application/json. The clue was from here.

I made this change and it works great on Android now! Just to ensure it didn't break anything, I think you should test it again on iOS @hjiangsu. Then we're good to go!

@hjiangsu
Copy link
Member Author

hjiangsu commented Sep 2, 2023

@micahmo Just tested it on iOS and it seems to be working as intended!

@micahmo
Copy link
Member

micahmo commented Sep 3, 2023

Just tested it on iOS and it seems to be working as intended!

Great, I think we're ready to merge once this branch is up to date.

@hjiangsu
Copy link
Member Author

hjiangsu commented Sep 5, 2023

Updated and ready!

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I forgot to approve!

@micahmo micahmo merged commit 8701309 into develop Sep 5, 2023
1 check passed
@micahmo micahmo deleted the feature/import-export-prefs branch September 5, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants