-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing and Exporting Settings to JSON #644
Conversation
@micahmo feel free to test this out on Android to make sure all the permissions are enabled for storage! |
Will do! If it works on Android, are you ready to merge? |
Yeah, I think this can be merged in if its all good - I just have the settings placed in the general settings, but we can move that around after if needed! |
Just a quick update on this. Unfortunately it's crashing on Android for me with this error.
Need more time to investigate! |
Alright, I tracked this one down! Apparently the issue was related to the MIME type, and just I made this change and it works great on Android now! Just to ensure it didn't break anything, I think you should test it again on iOS @hjiangsu. Then we're good to go! |
@micahmo Just tested it on iOS and it seems to be working as intended! |
Great, I think we're ready to merge once this branch is up to date. |
…/import-export-prefs
Updated and ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I forgot to approve!
Pull Request Description
Initial implementation for handling exporting and importing app settings to device. This saves a JSON file containing the user preferences.
This has been tested a bit on iOS, would need to check functionality on Android devices
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabel
s where applicable for accessibility?