Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semantic labeling of sort picker #654

Merged
merged 7 commits into from
Aug 27, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Aug 17, 2023

Pull Request Description

This PR fixes #649 by adding an explicit semantic label to the top-level widget, which indicates both the heading and the back button, and excluding semantics on the text widget.

Review without whitespace.

Issue Being Fixed

Issue Number: #649

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@ajsosa ajsosa merged commit 0054c4e into thunder-app:develop Aug 27, 2023
1 check passed
@micahmo micahmo deleted the fix/649-sort-picker-semantics branch August 28, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants