Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure snackbar appears over image viewer #661

Merged
merged 3 commits into from
Aug 20, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Aug 20, 2023

Pull Request Description

This PR fixes an issue where the snackbar for image download errors would appear under the image viewer.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

snackbar-before.mp4

After

qemu-system-x86_64_woJGCnQM0E.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable? -- N/A
  • Did you add semanticLabels where applicable for accessibility? -- N/A

Copy link
Collaborator

@ajsosa ajsosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ajsosa ajsosa merged commit 0c7b03e into thunder-app:develop Aug 20, 2023
1 check passed
@micahmo micahmo deleted the fix/snackbar-image-viewer branch August 21, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants