Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/post user identifiers #669

Merged
merged 7 commits into from
Aug 29, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Aug 21, 2023

Pull Request Description

This PR adds the special user identifier chips to the usernames in the post view. To reuse code, some refactoring was done as well.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Normal User (OP is implied)

image

Mod

image

Admin + Mod

image

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@CTalvio
Copy link
Collaborator

CTalvio commented Aug 23, 2023

A nitpick, but same as with comments, the chip now offsets the location of the actual username. I notice this.

Should we have the same username deets display in the feed? I feel like it's all getting awfully crowded.

@micahmo
Copy link
Member Author

micahmo commented Aug 23, 2023

the chip now offsets the location of the actual username

I think I would rather this than have the chip extend to the left of the margin. Here it wouldn't be a big deal but in comments it would be funny for any content to be to the left of where the comment text is.

Should we have the same username deets display in the feed? I feel like it's all getting awfully crowded.

Yeah I agree on crowded. Maybe we can revisit. If anything, maybe we can just color the foreground rather than adding a whole chip. Just an idea.

@CTalvio
Copy link
Collaborator

CTalvio commented Aug 23, 2023

We could also drop the highlight, and use just the icons.

Copy link
Collaborator

@ajsosa ajsosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ajsosa ajsosa merged commit e24909f into thunder-app:develop Aug 29, 2023
1 check passed
@micahmo micahmo deleted the feature/post-user-identifiers branch August 29, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants