-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/post user identifiers #669
Feature/post user identifiers #669
Conversation
A nitpick, but same as with comments, the chip now offsets the location of the actual username. I notice this. Should we have the same username deets display in the feed? I feel like it's all getting awfully crowded. |
I think I would rather this than have the chip extend to the left of the margin. Here it wouldn't be a big deal but in comments it would be funny for any content to be to the left of where the comment text is.
Yeah I agree on crowded. Maybe we can revisit. If anything, maybe we can just color the foreground rather than adding a whole chip. Just an idea. |
We could also drop the highlight, and use just the icons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Pull Request Description
This PR adds the special user identifier chips to the usernames in the post view. To reuse code, some refactoring was done as well.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Normal User (OP is implied)
Mod
Admin + Mod
Checklist
semanticLabel
s where applicable for accessibility?