Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed NPE that broke commenting #681

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Fixed NPE that broke commenting #681

merged 2 commits into from
Aug 23, 2023

Conversation

ajsosa
Copy link
Collaborator

@ajsosa ajsosa commented Aug 23, 2023

Pull Request Description

Fixed NPE that broke commenting

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

micahmo
micahmo approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it null when you're leaving a top-level comment and not null when you're replying?

@ajsosa
Copy link
Collaborator Author

ajsosa commented Aug 23, 2023

Yep, that's exactly what's happening.

@micahmo micahmo merged commit 31a4883 into thunder-app:develop Aug 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahmo micahmo micahmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajsosa @micahmo