Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove thumbnail progress indicators #691

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Aug 26, 2023

Pull Request Description

This PR removes some usage of loading indicators (CircularProgressIndicator).

Currently, there are loading indicators for images and link previews. On Android, these indicators are incosistent in size and thickness, and on iOS, they're totally different styles. They give the general impression that things are constantly loading. In other apps, there are no such indicators; images just fade in when available. In my opinion (again, this is just a matter of preference) that looks much cleaner.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

qemu-system-x86_64_EEZxVVooTn.mp4

After

qemu-system-x86_64_60q4u8kheK.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@ajsosa
Copy link
Collaborator

ajsosa commented Aug 27, 2023

Personally I like this change and would prefer it, but maybe we should get some feedback from @hjiangsu and others.

@CTalvio
Copy link
Collaborator

CTalvio commented Aug 30, 2023

Personally I like this change and would prefer it, but maybe we should get some feedback from @hjiangsu and others.

I also think it makes sense.

@machinaeZER0
Copy link
Collaborator

I love it! Any extra performance benefit from this change? Either way it seems like a good one to me :)

@micahmo
Copy link
Member Author

micahmo commented Sep 5, 2023

Any extra performance benefit from this change?

No, this is just cosmetic. But in my opinion it does feel better.😊

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, after looking at the video previews, it does look better.

I'll approve this and merge it in once the merge conflicts are fixed!

@micahmo
Copy link
Member Author

micahmo commented Sep 5, 2023

All set!

@hjiangsu hjiangsu merged commit 877a827 into thunder-app:develop Sep 5, 2023
1 check passed
@micahmo micahmo deleted the feature/remove-spinners branch September 5, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants